Port to rustix, drop nix#670
Merged
Merged
Conversation
travier
approved these changes
Jun 20, 2024
travier
left a comment
travier
left a comment
Member
There was a problem hiding this comment.
The syncfs rework is tricky and I'm not sure I fully understand it but LGTM overall.
Member
|
CI failing on: similarly in #669. |
Member
|
Looks like we need a new skopeo in the GitHub runner images :/ |
Member
We already have rustix as a dependency; now that we don't use IPC anymore it's trivial to port to rustix. I prefer its API and maintainer. Signed-off-by: Colin Walters <walters@verbum.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already have rustix as a dependency; now that we don't use IPC anymore it's trivial to port to rustix. I prefer its API and maintainer.